Bug 249174 - [ews-build.webkit.org] Use twisted deferred to communicate with commits.webkit.org
Summary: [ews-build.webkit.org] Use twisted deferred to communicate with commits.webki...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 250771
  Show dependency tree / graph
 
Reported: 2022-12-12 14:03 PST by Jonathan Bedard
Modified: 2023-01-18 10:29 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-12-12 14:03:28 PST 
We should use Twisted's deferred to communicate with commits.webkit.org in order to not block the main thread. We should also use Twisted's deferred when sleeping in code near the code that communicates with commits.webkit.org.
Comment 1 Radar WebKit Bug Importer 2022-12-12 14:03:46 PST 
<rdar://problem/103269096>
Comment 2 Jonathan Bedard 2022-12-12 14:16:05 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7507
Comment 3 EWS 2022-12-16 19:40:26 PST 
Committed 258032@main (eb4a573dc732): <https://commits.webkit.org/258032@main>

Reviewed commits have been landed. Closing PR #7507 and removing active labels.