Bug 249165 – [IFC][Integration] Enable nested out-of-flow boxes for IFC

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 464013 [details]
Patch

[Antti Koivisto]

Comment on attachment 464013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464013&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:126
> +        RenderElement* containingBlock = nullptr;
> +        if (renderer.isOutOfFlowPositioned()) {
> +            // Here we are looking for the containing block as if the out-of-flow box was inflow (for static position purpose).
> +            containingBlock = renderer.parent();
> +            if (is<RenderInline>(containingBlock))
> +                containingBlock = containingBlock->containingBlock();
> +        } else if (renderer.isFloating())
> +            containingBlock = renderer.containingBlock();

I feel there is lambda here.

[Antti Koivisto]

Comment on attachment 464013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464013&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-400
> -            // FIXME: We don't collect out-of-flow boxes from nested subtrees.
> -            if (renderer.parent() != renderer.containingBlock())
> -                return false;

Nice!

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 464013 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464013&action=review
> 
> > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:126
> > +        RenderElement* containingBlock = nullptr;
> > +        if (renderer.isOutOfFlowPositioned()) {
> > +            // Here we are looking for the containing block as if the out-of-flow box was inflow (for static position purpose).
> > +            containingBlock = renderer.parent();
> > +            if (is<RenderInline>(containingBlock))
> > +                containingBlock = containingBlock->containingBlock();
> > +        } else if (renderer.isFloating())
> > +            containingBlock = renderer.containingBlock();
> 
> I feel there is lambda here.
haha

[zalan]

Created attachment 464015 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/103304375>

[zalan]

Created attachment 464025 [details]
Patch

[EWS]

Committed 257802@main (a5081fa2fab8): <https://commits.webkit.org/257802@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464025 [details].