Bug 24916 - REGRESSION: NavigationAction policy dispatch broken
: REGRESSION: NavigationAction policy dispatch broken
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-03-28 17:11 PST by
Modified: 2009-03-30 10:26 PST (History)


Attachments
reduced test case (395 bytes, text/html)
2009-03-30 06:46 PST, Gustavo Noronha (kov)
no flags Details
patch (2.77 KB, patch)
2009-03-30 10:22 PST, Darin Adler
aroben: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-03-28 17:11:39 PST
In www.reddit.com, when clicking any link to the comments (those with name XXX comments, where XXX is a number), the data that arrives to the dispatchDecidePolicyForNavigationAction is incomplete: the action type is wrong, and the event associated with it lacks any data about button the key modifier keys pressed.

This was working in r42054, and I'd say it broke in the next commit by Darin (r42055), but I won't get to test it properly tonight.
------- Comment #1 From 2009-03-28 18:11:40 PST -------
I tried building the revision 42055 with the patch from 42069 (gtk+ build fix after 42055), and it doesn't work, indeed. I also tried revision 42054 with the patch from 42069, just to be sure it is not our fix that breaks it, and it works. So it seems like 42055 caused the problem, indeed.
------- Comment #2 From 2009-03-30 06:46:12 PST -------
Created an attachment (id=29072) [details]
reduced test case

The problem seems to happen for links with target="_parent". I haven't bothered creating a page with actual framesets, but that may be a good thing to do for a layout test.
------- Comment #3 From 2009-03-30 10:22:58 PST -------
Created an attachment (id=29076) [details]
patch
------- Comment #4 From 2009-03-30 10:25:40 PST -------
(From update of attachment 29076 [details])
r=me
------- Comment #5 From 2009-03-30 10:26:46 PST -------
http://trac.webkit.org/changeset/42108