Bug 24916 - REGRESSION: NavigationAction policy dispatch broken
: REGRESSION: NavigationAction policy dispatch broken
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To: Darin Adler
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-03-28 17:11 PDT by Xan Lopez
Modified: 2009-03-30 10:26 PDT (History)
1 user (show)

See Also:


Attachments
reduced test case (395 bytes, text/html)
2009-03-30 06:46 PDT, Gustavo Noronha (kov)
no flags Details
patch (2.77 KB, patch)
2009-03-30 10:22 PDT, Darin Adler
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-03-28 17:11:39 PDT
In www.reddit.com, when clicking any link to the comments (those with name XXX comments, where XXX is a number), the data that arrives to the dispatchDecidePolicyForNavigationAction is incomplete: the action type is wrong, and the event associated with it lacks any data about button the key modifier keys pressed.

This was working in r42054, and I'd say it broke in the next commit by Darin (r42055), but I won't get to test it properly tonight.
Comment 1 Gustavo Noronha (kov) 2009-03-28 18:11:40 PDT
I tried building the revision 42055 with the patch from 42069 (gtk+ build fix after 42055), and it doesn't work, indeed. I also tried revision 42054 with the patch from 42069, just to be sure it is not our fix that breaks it, and it works. So it seems like 42055 caused the problem, indeed.
Comment 2 Gustavo Noronha (kov) 2009-03-30 06:46:12 PDT
Created attachment 29072 [details]
reduced test case

The problem seems to happen for links with target="_parent". I haven't bothered creating a page with actual framesets, but that may be a good thing to do for a layout test.
Comment 3 Darin Adler 2009-03-30 10:22:58 PDT
Created attachment 29076 [details]
patch
Comment 4 Adam Roben (:aroben) 2009-03-30 10:25:40 PDT
Comment on attachment 29076 [details]
patch

r=me
Comment 5 Darin Adler 2009-03-30 10:26:46 PDT
http://trac.webkit.org/changeset/42108