Bug 249140 - Fix reset to baseVal after animation end for SVGTransformList
Summary: Fix reset to baseVal after animation end for SVGTransformList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-12 05:31 PST by Nikolas Zimmermann
Modified: 2023-10-06 06:03 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-12-12 05:31:41 PST
Partly revert the fix from webkit.org/b/198576 (REGRESSION (r243121): Load event
should not be fired while animating the 'externalResourcesRequired' attribute),
that landed in https://commits.webkit.org/212621@main.
    
First of all, externalResourcesRequired support is gone from WebKit, therefore
SMIL animations of that property are no longer possible: the workaround is obsolete.
    
More importantly, the applied workaround is harmful for SVGTransformList animations,
which go through the same SVGAnimatedPropertyAnimator code paths to apply changes,
when <animateTransform> animations are active.

@said: I hope the ChangeLog is sufficient :-)
[I wanted to mark this as depends-on 198576, but I have no rights to do so]
Comment 1 Nikolas Zimmermann 2022-12-12 05:33:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/7481
Comment 2 Nikolas Zimmermann 2022-12-12 05:34:06 PST
It's a draft PR, still need to update baseline / eventually add a new test (broke this out of a chain of commits, waiting for my builds to catch up... :-)
Comment 3 Radar WebKit Bug Importer 2022-12-19 05:32:15 PST
<rdar://problem/103512849>
Comment 4 EWS 2023-10-06 06:03:37 PDT
Committed 268987@main (5a8f69dc67ce): <https://commits.webkit.org/268987@main>

Reviewed commits have been landed. Closing PR #7481 and removing active labels.