Bug 249107 – canonicalUnitTypeForCategory should handle percent category

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Fix some FIXMEs.

[Radar WebKit Bug Importer]

<rdar://problem/103231020>

[Antti Koivisto]

Created attachment 463989 [details]
Patch

[Antti Koivisto]

Created attachment 463990 [details]
Patch

[Antti Koivisto]

Created attachment 464000 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 464000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464000&action=review

> Source/WebCore/css/typedom/CSSUnitValue.cpp:161
>      auto canonicalUnit = [] (CSSUnitType unit) {
> -        // FIXME: We probably want to change the definition of canonicalUnitTypeForCategory so this lambda isn't necessary.
> -        auto category = unitCategory(unit);
> -        switch (category) {
> -        case CSSUnitCategory::Percent:
> -            return CSSUnitType::CSS_PERCENTAGE;
> -        case CSSUnitCategory::Flex:
> -            return CSSUnitType::CSS_FR;
> -        default:
> -            break;
> -        }
> -        auto result = canonicalUnitTypeForCategory(category);
> +        auto result = canonicalUnitTypeForUnitType(unit);
>          return result == CSSUnitType::CSS_UNKNOWN ? unit : result;
>      } (m_unit);

Do we really need this lambda? Can we just call `canonicalUnitTypeForUnitType` directly ?

[Antti Koivisto]

Created attachment 464002 [details]
Patch for landing

[EWS]

Committed 257716@main (f23f94eab4ca): <https://commits.webkit.org/257716@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464002 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 249131

[Philippe Normand]

Manually reverted, see https://bugs.webkit.org/show_bug.cgi?id=249133

[Philippe Normand]

Revert no longer needed.