Bug 249078 - DataDetection.mm fails to build with newer clang when initializing DDQueryOffset
Summary: DataDetection.mm fails to build with newer clang when initializing DDQueryOffset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-10 14:37 PST by David Kilzer (:ddkilzer)
Modified: 2022-12-10 15:02 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2022-12-10 14:37:40 PST 
DataDetection.mm fails to build with newer clang when initializing DDQueryOffset.

    Source/WebCore/editing/cocoa/DataDetection.mm:549:53: error: missing field 'offset' initializer [-Werror,-Wmissing-field-initializers]

The current code does this:

    DDQueryOffset lastModifiedQueryOffset = { -1, 0 };

The DDQueryOffset type is defined as:

    typedef struct __DDQueryOffset {
        CFIndex queryIndex:32;
        CFIndex offset:32;
    } DDQueryOffset;
Comment 1 David Kilzer (:ddkilzer) 2022-12-10 14:39:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7446
Comment 2 Radar WebKit Bug Importer 2022-12-10 14:40:41 PST 
<rdar://problem/103217701>
Comment 3 EWS 2022-12-10 15:02:10 PST 
Committed 257687@main (68b73575a9aa): <https://commits.webkit.org/257687@main>

Reviewed commits have been landed. Closing PR #7446 and removing active labels.