WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
249045
[ews] Improve handling of non-existing status-bubbles
https://bugs.webkit.org/show_bug.cgi?id=249045
Summary
[ews] Improve handling of non-existing status-bubbles
Aakash Jain
Reported
2022-12-09 14:34:13 PST
[ews] Improve handling of non-existing status-bubbles on Github.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-09 14:34:50 PST
<
rdar://problem/103194910
>
Aakash Jain
Comment 2
2022-12-09 14:36:31 PST
Exception from logs: File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 230, in generate_comment_text_for_change comment_for_row += self.github_status_for_queue(change, queue) File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/common/github.py", line 272, in github_status_for_queue return u'| [{icon} {name} ]({url} "{hover_over_text}") '.format(icon=icon, name=name, url=url, hover_over_text=hover_over_text) UnboundLocalError: local variable 'url' referenced before assignment
Aakash Jain
Comment 3
2022-12-09 14:37:06 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7410
EWS
Comment 4
2022-12-09 15:11:50 PST
Committed
257648@main
(7d063a43b838): <
https://commits.webkit.org/257648@main
> Reviewed commits have been landed. Closing PR #7410 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug