Bug 248966 - Drop shouldForceEnclosingCalcInCSSText flag recently added to CSSCalcExpressionNode
Summary: Drop shouldForceEnclosingCalcInCSSText flag recently added to CSSCalcExpressi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 175733
  Show dependency tree / graph
 
Reported: 2022-12-08 11:52 PST by Chris Dumez
Modified: 2022-12-09 04:16 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-12-08 11:52:55 PST 
Drop shouldForceEnclosingCalcInCSSText flag that was recently added to CSSCalcExpressionNode in 257485@main. We don't need it, we can simply wrap the number in a sum to make sure that the surrounding `calc()` isn't dropped during serialization.
Comment 1 Chris Dumez 2022-12-08 11:54:42 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7337
Comment 2 EWS 2022-12-09 04:15:55 PST 
Committed 257619@main (0476db43bf13): <https://commits.webkit.org/257619@main>

Reviewed commits have been landed. Closing PR #7337 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-09 04:16:27 PST 
<rdar://problem/103176800>