WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248925
Sum & Product calculation node children should only get sorted for serialization
https://bugs.webkit.org/show_bug.cgi?id=248925
Summary
Sum & Product calculation node children should only get sorted for serialization
Chris Dumez
Reported
2022-12-07 19:40:00 PST
Sum & Product calculation node children should only get sorted for serialization, as per: -
https://drafts.csswg.org/css-values-4/#serialize-a-calculation-tree
-
https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
However, we were doing this eagerly after parsing the calculation value, during the simplification step: -
https://w3c.github.io/csswg-drafts/css-values/#calc-simplification
This is observable with CSS Typed OM since the following: `CSSStyleValue.parse("width", "calc(1px + 1em)")` would get parsed as `new CSSMathSum(CSS.em(1), CSS.px(1))` instead of `new CSSMathSum(CSS.px(1), CSS.em(1))`
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2022-12-07 19:47:28 PST
Pull request:
https://github.com/WebKit/WebKit/pull/7301
EWS
Comment 2
2022-12-08 10:31:25 PST
Committed
257573@main
(e06fc205e555): <
https://commits.webkit.org/257573@main
> Reviewed commits have been landed. Closing PR #7301 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2022-12-08 10:32:18 PST
<
rdar://problem/103136508
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug