Bug 248888 - Stop reversing child expression in reifyMathExpression()
Summary: Stop reversing child expression in reifyMathExpression()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 175733
  Show dependency tree / graph
 
Reported: 2022-12-07 09:38 PST by Chris Dumez
Modified: 2022-12-07 19:34 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-12-07 09:38:27 PST 
Stop reversing child expression in reifyMathExpression(). As far as I can tell, this ends up being identical since those are children of a sum. However, the tests rely on a specific ordering when validating the results. When parsing something like "calc(1px + 1em)", we would end up with `1em` and first child and `1px` and second child, which was confusing.
Comment 1 Chris Dumez 2022-12-07 09:40:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7269