Bug 248879 - Properly resolve fullscreen API promises
Summary: Properly resolve fullscreen API promises
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-12-07 08:06 PST by Tim Nguyen (:ntim)
Modified: 2022-12-12 10:57 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-12-07 08:06:01 PST 
exitFullscreen() promises should resolve in FullscreenManager::finishExitFullscreen().

requestFullscreen() promises should resolve in FullscreenManager::willEnterFullscreen().

These methods FullscreenManager are called asynchronously, so it might be tricky however.
Comment 1 Tim Nguyen (:ntim) 2022-12-07 08:21:10 PST 
rdar://103074395
Comment 2 Tim Nguyen (:ntim) 2022-12-09 15:16:40 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7415
Comment 3 EWS 2022-12-09 20:03:55 PST 
Committed 257668@main (9696329f7af6): <https://commits.webkit.org/257668@main>

Reviewed commits have been landed. Closing PR #7415 and removing active labels.
Comment 4 David Kilzer (:ddkilzer) 2022-12-10 10:12:52 PST 
I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now.
Comment 5 David Kilzer (:ddkilzer) 2022-12-12 10:30:41 PST 
(In reply to David Kilzer (:ddkilzer) from comment #4)
> I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now.

Specific examples:


PR:  <https://github.com/WebKit/WebKit/pull/7430>
Run:  <https://ews-build.webkit.org/#/builders/73/builds/21968>
Results:  <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/c887a3c0-21968/results.html>

Crashing tests:
fullscreen/full-screen-request-removed.html
media/modern-media-controls/layout-node/addChild.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
media/modern-media-controls/seek-forward-support/seek-forward-support.html


PR:  <https://github.com/WebKit/WebKit/pull/7428>
Run:  <https://ews-build.webkit.org/#/builders/73/builds/21964>
Results:  <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/37345d6b-21964/results.html>

Crashing tests:
fullscreen/full-screen-request-removed.html	crash log sample	history
media/modern-media-controls/media-controls/media-controls-display-above-captions.html
media/modern-media-controls/mute-button/mute-button.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
media/modern-media-controls/start-support/start-support-audio.html
pageoverlay/overlay-large-document-scrolled.html

These seem to be fixed as of Monday morning, though.
Comment 6 Tim Nguyen (:ntim) 2022-12-12 10:57:08 PST 
Crashes were fixed by https://github.com/WebKit/WebKit/pull/7443