RESOLVED FIXED 24881
Fix WebInspector's ElementsTreeOutline to make valid editingCancelled call.
https://bugs.webkit.org/show_bug.cgi?id=24881
Summary Fix WebInspector's ElementsTreeOutline to make valid editingCancelled call.
Pavel Feldman
Reported 2009-03-27 06:32:08 PDT
Fix WebInspector's ElementsTreeOutline to make valid editingCancelled call.
Attachments
Patch with the fix (1.22 KB, patch)
2009-03-27 06:33 PDT, Pavel Feldman
timothy: review+
Pavel Feldman
Comment 1 2009-03-27 06:33:09 PDT
Created attachment 29008 [details] Patch with the fix
Maciej Stachowiak
Comment 2 2009-05-22 02:22:29 PDT
I don't understand this change. Why is the new way right? Maybe Tim Hatcher should look at this.
Pavel Feldman
Comment 3 2009-05-22 02:44:28 PDT
I think this has been landed / patched long ago.
David Kilzer (:ddkilzer)
Comment 4 2009-05-22 06:25:44 PDT
(In reply to comment #3) > I think this has been landed / patched long ago. Looking at r43858, it has not been landed. Reopening. http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOutline.js#L573
Pavel Feldman
Comment 5 2009-05-22 06:40:23 PDT
(In reply to comment #4) > (In reply to comment #3) > > I think this has been landed / patched long ago. > > Looking at r43858, it has not been landed. Reopening. > > http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOutline.js#L573 > Sorry, my bad. Timothy, could you take a quick look at this?
Timothy Hatcher
Comment 6 2009-05-22 08:49:39 PDT
This didn't land yet. Landing now.
Timothy Hatcher
Comment 7 2009-05-22 09:11:47 PDT
Note You need to log in before you can comment on or make changes to this bug.