Bug 248792 - [Wasm] Failures in ref_types.js test
Summary: [Wasm] Failures in ref_types.js test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-05 15:14 PST by Asumu Takikawa
Modified: 2022-12-08 15:41 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2022-12-05 15:14:02 PST 
There are currently some failing tests from the typed funcref tests (wasm.yaml/wasm/function-references/ref_types.js). It looks like a difference in type printing for `global.set` was introduced in 85f4c97a6e063901a359c620aa1007c7c3ebd7ea.

Either the test expectations should change or the type printing should change I think (https://bugs.webkit.org/show_bug.cgi?id=247452 made the type printing print the whole type instead of just the kind in other places, so it could make sense to be consistent with that).
Comment 1 Asumu Takikawa 2022-12-08 15:41:22 PST 
This was fixed recently in https://github.com/WebKit/WebKit/commit/c3cabf531d738de5d543050e84fc0584b58fc449 and can be closed.