Bug 24878 - [GTK] Use GtkBinding system to handle key events in WebView
Summary: [GTK] Use GtkBinding system to handle key events in WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-27 01:43 PDT by Xan Lopez
Modified: 2009-03-30 08:49 PDT (History)
0 users

See Also:

Attachments
webviewbindings.patch (13.06 KB, patch)
2009-03-27 01:47 PDT, Xan Lopez 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-03-27 01:43:21 PDT 
Patch coming.
Comment 1 Xan Lopez 2009-03-27 01:47:15 PDT 
Created attachment 29005 [details]
webviewbindings.patch
Comment 2 Holger Freyther 2009-03-30 06:04:45 PDT 
Comment on attachment 29005 [details]
webviewbindings.patch


> +    case GTK_MOVEMENT_VISUAL_POSITIONS:
> +        if (count == 1)
> +            view->scrollBy(IntSize(cScrollbarPixelsPerLineStep, 0));
> +        else if (count == -1)
> +            view->scrollBy(IntSize(-cScrollbarPixelsPerLineStep, 0));
> +      break;

wrongly placed.



yeah!!!
Comment 3 Xan Lopez 2009-03-30 08:49:00 PDT 
Thanks, committed as r42102.