Bug 248769 – [LegacySVG] Return vertical writing mode aware intrinsic information for SVG

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across following commit:

Commit - https://chromium.googlesource.com/chromium/blink/+/60af46f13e39be1daacbcdab27c4e7212ae27886

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a/Source/WebCore/rendering/svg/RenderSVGRoot.cpp#LL108 & https://github.com/WebKit/WebKit/blob/ecaf5946d7a021d6e1d8bda4bb6e2c990a73d26a/Source/WebCore/rendering/svg/RenderSVGRoot.cpp#L118

Test Failing (Firefox Nightly 109 & Chrome Canary 110 passes) - https://jsfiddle.net/28hwu6cy/show

Just wanted to raise bug before trying to merge this fix.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/103262534>

[Ahmad Saleem]

    if (!isHorizontalWritingMode())
        intrinsicSize = intrinsicSize.transposedSize();    

 if (!isHorizontalWritingMode())
                intrinsicRatioValue = 1 / intrinsicRatio

^ This make us pass another one of the test similar to Blink patch. I tried that in the past but didn't work. I might have done something silly.

[Ahmad Saleem]

https://github.com/WebKit/WebKit/pull/14014 <- at least fixing one test case.

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/54490

[Ahmad Saleem]

*** Bug 256962 has been marked as a duplicate of this bug. ***

[EWS]

Committed 303578@main (0c4398970715): <https://commits.webkit.org/303578@main>

Reviewed commits have been landed. Closing PR #54490 and removing active labels.

[Ahmad Saleem]

*** Bug 186595 has been marked as a duplicate of this bug. ***