Bug 24876 - fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2)
Summary: fast/forms/select-max-length.html times out in debug builds due to HTMLSelect...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 24889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-26 22:08 PDT by Mark Rowe (bdash)
Modified: 2009-03-27 14:34 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2009-03-26 22:08:37 PDT 
After <http://trac.webkit.org/changeset/42012>, fast/forms/select-max-length.html is frequently timing out on my MacBook Pro in a debug build.  Running the test manually shows it takes around 17 seconds to complete, which is above the new 15s threshold.
Comment 1 Simon Fraser (smfr) 2009-03-26 22:09:57 PDT 
It looks like HTMLSelectElement::setLength() is O(N^2)
Comment 2 Adam Roben (:aroben) 2009-03-27 09:02:11 PDT 
Maybe we should back out r42012
Comment 3 Adam Roben (:aroben) 2009-03-27 09:02:37 PDT 
(Obviously it would be good to improve the test's performance, too!)
Comment 4 Mark Rowe (bdash) 2009-03-27 09:58:03 PDT 
*** Bug 24889 has been marked as a duplicate of this bug. ***
Comment 5 Mark Rowe (bdash) 2009-03-27 09:59:38 PDT 
Fixing HTMLSelectElement::setLength would be a better idea, unless there are other tests also timing out.
Comment 6 Mark Rowe (bdash) 2009-03-27 14:09:34 PDT 
I have a patch that drops the time of this test from 17 seconds down to around 4.5 seconds by improving HTMLSelectElement::setLength.  I need to verify that the change is safe in the face of fun things like mutation events, and then will put a patch up for review.
Comment 7 Mark Rowe (bdash) 2009-03-27 14:34:17 PDT 
Fixed in r42050.