Bug 24861 - Chromium port does not render decorations for <input type="search">
Summary: Chromium port does not render decorations for <input type="search">
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-26 16:36 PDT by Peter Kasting
Modified: 2009-03-27 11:08 PDT (History)
1 user (show)

See Also:

Attachments
patch v1 (22.23 KB, patch)
2009-03-26 16:37 PDT, Peter Kasting 		no flags Details | Formatted Diff | Diff
patch v2 (22.45 KB, patch)
2009-03-26 16:55 PDT, Peter Kasting 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2009-03-26 16:36:15 PDT 
Patch coming shortly
Comment 1 Peter Kasting 2009-03-26 16:37:14 PDT 
Created attachment 28993 [details]
patch v1
Comment 2 Peter Kasting 2009-03-26 16:55:06 PDT 
Created attachment 28994 [details]
patch v2

Now compiles on Linux, hopefully
Comment 3 Eric Seidel (no email) 2009-03-26 17:23:47 PDT 
Comment on attachment 28994 [details]
patch v2

Peter informs me this is just copy/paste code.  That seems like a really bad idea.  Especially for this volume of code.  Can't we use a RenderThemeChromium superclass here?
Comment 4 Eric Seidel (no email) 2009-03-26 17:53:27 PDT 
Comment on attachment 28994 [details]
patch v2

Peter says he's about to refactor this as his next patch.  So this is a fine intermediate step.
Comment 5 Peter Kasting 2009-03-27 11:08:04 PDT 
Fixed in r42044.