WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248590
AX: Make crash-in-element-for-text-marker.html and aria-liveregions-attributes.html async-friendly so they can pass in ITM
https://bugs.webkit.org/show_bug.cgi?id=248590
Summary
AX: Make crash-in-element-for-text-marker.html and aria-liveregions-attribute...
Tyler Wilcock
Reported
2022-12-01 00:37:36 PST
AX: Make crash-in-element-for-text-marker.html and aria-liveregions-attributes.html async-friendly so they can pass in ITM
Attachments
Patch
(17.89 KB, patch)
2022-12-01 00:42 PST
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Patch
(17.94 KB, patch)
2022-12-01 09:57 PST
,
Tyler Wilcock
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-01 00:37:48 PST
<
rdar://problem/102849570
>
Tyler Wilcock
Comment 2
2022-12-01 00:42:21 PST
Created
attachment 463826
[details]
Patch
Andres Gonzalez
Comment 3
2022-12-01 07:11:13 PST
(In reply to Tyler Wilcock from
comment #2
)
> Created
attachment 463826
[details]
> Patch
--- a/LayoutTests/resources/accessibility-helper.js +++ b/LayoutTests/resources/accessibility-helper.js @@ -177,6 +177,11 @@ async function expectAsyncExpression(expression, expectedValue) { debug(`PASS ${evalExpression}`); } +async function waitForFocus(id) { + document.getElementById(id).focus(); + await waitFor(() => accessibilityController.focusedElement && accessibilityController.focusedElement.domIdentifier === id); +} Would it be a bit more performant if we don't call accessibilityController.focusedElement twice? This may be called a bunch of times like in the first test in this patch.
Tyler Wilcock
Comment 4
2022-12-01 09:57:27 PST
Created
attachment 463837
[details]
Patch
EWS
Comment 5
2022-12-03 02:20:26 PST
Committed
257319@main
(fb7087c033ee): <
https://commits.webkit.org/257319@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 463837
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug