Bug 248569 - Support ::backdrop renderers on all elements
Summary: Support ::backdrop renderers on all elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-30 15:58 PST by Tim Nguyen (:ntim)
Modified: 2022-12-03 16:11 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-11-30 15:58:11 PST 
Some renderers don't expect extra children like RenderVideo, which causes the ::backdrop to not be laid out. We could fix all renderers to lay out children, but that's probably unnecessary complexity and it's likely to miss certain cases.

So let's append all ::backdrop to the RenderView whenever we can.
Comment 1 Radar WebKit Bug Importer 2022-11-30 15:59:05 PST 
<rdar://problem/102833504>
Comment 2 Tim Nguyen (:ntim) 2022-11-30 16:00:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6997
Comment 3 Tim Nguyen (:ntim) 2022-11-30 19:05:17 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7005
Comment 4 EWS 2022-12-03 16:11:47 PST 
Committed 257337@main (fc7f34162f24): <https://commits.webkit.org/257337@main>

Reviewed commits have been landed. Closing PR #7005 and removing active labels.