Bug 248568 - [WebAssembly SIMD] Support vector comparisons on Intel
Summary: [WebAssembly SIMD] Support vector comparisons on Intel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on:
Blocks: 246345
  Show dependency tree / graph
 
Reported: 2022-11-30 15:49 PST by David Degazio
Modified: 2022-12-07 18:21 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2022-11-30 15:49:15 PST 
We should add support for vector comparison instructions to the x86_64 macro assembler.
Comment 1 David Degazio 2022-12-01 16:45:41 PST 
For reference, this involves adding support for the following instructions:

 - i8x16.eq, i16x8.eq, i32x4.eq, i64x2.eq, f32x4.eq, f64x2.eq
 - i8x16.ne, i16x8.ne, i32x4.ne, i64x2.ne, f32x4.ne, f64x2.ne
 - f32x4.lt, f64x2.lt
 - f32x4.le, f64x2.le
 - f32x4.gt, f64x2.gt
 - f32x4.ge, f64x2.ge
 - i8x16.lt_s, i16x8.lt_s, i32x4.lt_s, i64x2.lt_s
 - i8x16.le_s, i16x8.le_s, i32x4.le_s, i64x2.le_s
 - i8x16.gt_s, i16x8.gt_s, i32x4.gt_s, i64x2.gt_s
 - i8x16.ge_s, i16x8.ge_s, i32x4.ge_s, i64x2.ge_s
 - i8x16.lt_u, i16x8.lt_u, i32x4.lt_u
 - i8x16.le_u, i16x8.le_u, i32x4.le_u
 - i8x16.gt_u, i16x8.gt_u, i32x4.gt_u
 - i8x16.ge_u, i16x8.ge_u, i32x4.ge_u
Comment 2 David Degazio 2022-12-07 14:22:31 PST 
rdar://103089559
Comment 3 David Degazio 2022-12-07 15:23:13 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7290
Comment 4 EWS 2022-12-07 18:21:06 PST 
Committed 257532@main (c6145db418b3): <https://commits.webkit.org/257532@main>

Reviewed commits have been landed. Closing PR #7290 and removing active labels.