Bug 248567 – SVG text is always underlined when SVG is wrapped by an A element

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While going through Blink's commit, I came across another failing test case in Safari:

Failing Test case - https://jsfiddle.net/fhcw9w50/2/

^ "Some Text" should not be underlined like other browsers.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=199132

Just wanted to raise bug so it can be fixed in future.

Thanks!

[Ahmad Saleem]

Note - this is not 1:1 because this commit changed the code:

https://github.com/WebKit/WebKit/commit/af6b61d40471b08d5d6c1acb90c5d533d92805d8

[Radar WebKit Bug Importer]

<rdar://problem/103093226>

[Ahmad Saleem]

Fixed it locally by adding following:

in StyleAdjuster.cpp

static bool isOutermostSVGElement (const Element* element)
{
    return element && element->isSVGElement() && downcast<SVGElement>(*element).isOutermostSVGSVGElement();
}

and

following in 'shouldInheritTextDecorationsInEffect':

if (isOutermostSVGElement(element))
        return false;

[EWS]

Committed 264894@main (b3a3c589507e): <https://commits.webkit.org/264894@main>

Reviewed commits have been landed. Closing PR #14681 and removing active labels.