Bug 24854 – Rename PositionIterator members in hope of further clarity

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Eric Seidel (no email)]

I'm going to make a bunch more small position cleanups today, before I start my 5th attempt to re-write positions. :)  Hopefully these cleanups will continue to clarify and simplify the code, and continue to solidify my understanding of the mess that is position handling code. ;)

[Eric Seidel (no email)]

Created attachment 28981 [details]
Rename PositionIterator members in hope of futher clarity

 WebCore/ChangeLog                |   28 ++++++++++
 WebCore/dom/PositionIterator.cpp |  112 +++++++++++++++++++-------------------
 WebCore/dom/PositionIterator.h   |   22 ++++----
 3 files changed, 95 insertions(+), 67 deletions(-)

[Eric Seidel (no email)]

Created attachment 28982 [details]
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree

 WebCore/ChangeLog                |   20 ++++++++++++++++++++
 WebCore/dom/Position.cpp         |    4 ++--
 WebCore/dom/PositionIterator.cpp |    4 ++--
 WebCore/dom/PositionIterator.h   |    4 ++--
 WebCore/editing/htmlediting.cpp  |    4 ++--
 5 files changed, 28 insertions(+), 8 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 28982 [details]
Rename PositionIterator::atStart/atEnd atStartOfTree/atEndOfTree

Gonna remake this second patch to include more renames.

[Eric Seidel (no email)]

Created attachment 28990 [details]
More cleanup and renaming to PositionIterator

 WebCore/ChangeLog                 |   35 +++++++++++++-
 WebCore/dom/Position.cpp          |   14 +++---
 WebCore/dom/PositionIterator.cpp  |   98 +++++++++++++++++++++++--------------
 WebCore/dom/PositionIterator.h    |   14 +++--
 WebCore/editing/VisiblePosition.h |    5 ++
 WebCore/editing/htmlediting.cpp   |    4 +-
 6 files changed, 118 insertions(+), 52 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 28990 [details]
More cleanup and renaming to PositionIterator

There is a missing return.  Will upload fixed patch.

[Maciej Stachowiak]

It would be good for someone familiar with PositionIterator such as Justin or Darin to chime in,

[Darin Adler]

Comment on attachment 28981 [details]
Rename PositionIterator members in hope of futher clarity

I think "anchor" is a little vague, but the names seem fine here.

[David Levin]

Assigned to Eric for landing his own patch.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/PositionIterator.cpp
	M	WebCore/dom/PositionIterator.h
Committed r44374