Bug 24852 - Inconsistent flags might lead to link failure for ARM/RVCT release builds
Summary: Inconsistent flags might lead to link failure for ARM/RVCT release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-26 13:37 PDT by Laszlo Gombos
Modified: 2009-03-27 06:05 PDT (History)
3 users (show)

See Also:


Attachments
Revert change in PreloadScanner.cpp made by r40404 (1.07 KB, patch)
2009-03-26 14:04 PDT, Laszlo Gombos
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-03-26 13:37:39 PDT
Fix regression introduced by http://trac.webkit.org/changeset/40404.

During GNU mode RVCT compilation __GNUC__ is defined but COMPILER(GCC) is false. 

The output of gperf (HTMLEntityNames.c) generates code which will use the __GNUC__ flag; so PreloadScanner.cpp needs to use the __GNUC__ flag to stay consistent, otherwise GNU mode RVCT compilation will fail to link. 

The solution is to simply revert the change in PreloadScanner.cpp. 

Patch will follow.
Comment 1 Laszlo Gombos 2009-03-26 14:04:23 PDT
Created attachment 28985 [details]
Revert change in PreloadScanner.cpp made by r40404
Comment 2 Simon Hausmann 2009-03-27 06:05:04 PDT
Comment on attachment 28985 [details]
Revert change in PreloadScanner.cpp made by r40404

Looks good to me
Comment 3 Simon Hausmann 2009-03-27 06:05:23 PDT
Landed in r42036