Bug 248512 – REGRESSION(257087@main): WebHitTestResultData ctor should check the argument `imageHandle` is nullopt

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

[WinCairo] REGRESSION(257087@main): assertion failed in IPC::ArgumentCoder<WebKit::WebHitTestResultData,void>::decode

After 257087@main (bug#248079) added a new serializer for WebHitTestResultData, WinCairo is crashing.

ASSERTION FAILED: ::MapViewOfFile failed with error 6 CCCCCCCCCCCCCCCC
baseAddress
C:\home\webkit\gc\Source\WebKit\Platform\win\SharedMemoryWin.cpp(124) : WebKit::SharedMemory::adopt
C:\home\webkit\gc\Source\WebKit\Platform\win\SharedMemoryWin.cpp(124) : WebKit::SharedMemory::adopt
1   00007FF90405248B WTFCrash
1   00007FF90405248B WTFCrash
2   00007FF8AB64EB59 WebKit::SharedMemory::adopt
2   00007FF8AB64EB59 WebKit::SharedMemory::adopt
3   00007FF8AB64E9D5 WebKit::SharedMemory::map
3   00007FF8AB64E9D5 WebKit::SharedMemory::map
4   00007FF8AC651A98 WebKit::WebHitTestResultData::WebHitTestResultData
4   00007FF8AC651A98 WebKit::WebHitTestResultData::WebHitTestResultData
5   00007FF8ABE08C23 IPC::ArgumentCoder<WebKit::WebHitTestResultData,void>::decode
5   00007FF8ABE08C23 IPC::ArgumentCoder<WebKit::WebHitTestResultData,void>::decode
6   00007FF8ABA949A0 IPC::Decoder::decode<WebKit::WebHitTestResultData>
6   00007FF8ABA949A0 IPC::Decoder::decode<WebKit::WebHitTestResultData>
7   00007FF8ABA99FED IPC::ArgumentCoder<std::tuple<WebKit::WebHitTestResultData,unsigned int,WebKit::UserData>,void>::decode<IPC::Decoder>
7   00007FF8ABA99FED IPC::ArgumentCoder<std::tuple<WebKit::WebHitTestResultData,unsigned int,WebKit::UserData>,void>::decode<IPC::Decoder>
8   00007FF8ABA96670 IPC::Decoder::decode<std::tuple<WebKit::WebHitTestResultData,unsigned int,WebKit::UserData> >
8   00007FF8ABA96670 IPC::Decoder::decode<std::tuple<WebKit::WebHitTestResultData,unsigned int,WebKit::UserData> >
9   00007FF8ABACBCEA IPC::handleMessage<Messages::WebPageProxy::MouseDidMoveOverElement,WebKit::WebPageProxy,WebKit::WebPageProxy,void __cdecl(WebKit::WebHitTestResultData &&,unsigned int,WebKit::UserData &&)>
9   00007FF8ABACBCEA IPC::handleMessage<Messages::WebPageProxy::MouseDidMoveOverElement,WebKit::WebPageProxy,WebKit::WebPageProxy,void __cdecl(WebKit::WebHitTestResultData &&,unsigned int,WebKit::UserData &&)>
10  00007FF8ABA4CA1C WebKit::WebPageProxy::didReceiveMessage
10  00007FF8ABA4CA1C WebKit::WebPageProxy::didReceiveMessage
11  00007FF8AC599134 IPC::MessageReceiverMap::dispatchMessage
11  00007FF8AC599134 IPC::MessageReceiverMap::dispatchMessage
12  00007FF8AC6D2318 WebKit::AuxiliaryProcessProxy::dispatchMessage
12  00007FF8AC6D2318 WebKit::AuxiliaryProcessProxy::dispatchMessage
13  00007FF8AC774476 WebKit::WebProcessProxy::didReceiveMessage
13  00007FF8AC774476 WebKit::WebProcessProxy::didReceiveMessage
14  00007FF8AC5953F0 IPC::Connection::dispatchMessage
14  00007FF8AC5953F0 IPC::Connection::dispatchMessage
15  00007FF8AC595089 IPC::Connection::dispatchMessage
15  00007FF8AC595089 IPC::Connection::dispatchMessage
16  00007FF8AC594C3A IPC::Connection::dispatchIncomingMessages
16  00007FF8AC594C3A IPC::Connection::dispatchIncomingMessages
17  00007FF8AC597C8F `IPC::Connection::enqueueIncomingMessage'::`17'::<lambda_1>::operator()
17  00007FF8AC597C8F `IPC::Connection::enqueueIncomingMessage'::`17'::<lambda_1>::operator()
18  00007FF8AC59AAAB WTF::Detail::CallableWrapper<`IPC::Connection::enqueueIncomingMessage'::`17'::<lambda_1>,void>::call
18  00007FF8AC59AAAB WTF::Detail::CallableWrapper<`IPC::Connection::enqueueIncomingMessage'::`17'::<lambda_1>,void>::call
19  00007FF90406A473 WTF::Function<void __cdecl(void)>::operator()
19  00007FF90406A473 WTF::Function<void __cdecl(void)>::operator()
20  00007FF9040F7848 WTF::RunLoop::performWork
20  00007FF9040F7848 WTF::RunLoop::performWork
21  00007FF9041E10F1 WTF::RunLoop::wndProc
21  00007FF9041E10F1 WTF::RunLoop::wndProc
22  00007FF9041E1054 WTF::RunLoop::RunLoopWndProc
22  00007FF9041E1054 WTF::RunLoop::RunLoopWndProc
23  00007FF99993E858 CallWindowProcW
23  00007FF99993E858 CallWindowProcW
24  00007FF99993E299 DispatchMessageW
24  00007FF99993E299 DispatchMessageW
25  00007FF90969DC88 wWinMain
25  00007FF90969DC88 wWinMain
26  00007FF90969DE02 dllLauncherEntryPoint
26  00007FF90969DE02 dllLauncherEntryPoint
27  00007FF71E6014C9 wWinMain
27  00007FF71E6014C9 wWinMain
28  00007FF71E6058EE __scrt_common_main_seh
28  00007FF71E6058EE __scrt_common_main_seh
29  00007FF999F074B4 BaseThreadInitThunk
29  00007FF999F074B4 BaseThreadInitThunk
30  00007FF99B1226A1 RtlUserThreadStart
30  00007FF99B1226A1 RtlUserThreadStart
Exception thrown at 0x00007FF904052490 (WTF.dll) in MiniBrowser.exe: 0xC0000005: Access violation writing location 0x00000000BBADBEEF.

[Fujii Hironori]

Created attachment 463802 [details]
Patch

[Lauro Moura]

*** Bug 248516 has been marked as a duplicate of this bug. ***

[EWS]

Committed 257173@main (8d8cf5f510a9): <https://commits.webkit.org/257173@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463802 [details].

[Radar WebKit Bug Importer]

<rdar://problem/102803986>