WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248486
Potential crash fix by bailing from DeleteSelectionCommand::doApply when selection isn't editable
https://bugs.webkit.org/show_bug.cgi?id=248486
Summary
Potential crash fix by bailing from DeleteSelectionCommand::doApply when sele...
Ahmad Saleem
Reported
2022-11-29 12:19:46 PST
Hi Team, While going through Blink's commit, I found another potential merge, which can make Webkit more stable and not hit situation leading to crash on debug or release builds: Blink Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=190121
Webkit GitHub Source -
https://github.com/WebKit/WebKit/blob/7e26ee98dc891f869c003c1724f061a82d65bd2b/Source/WebCore/editing/DeleteSelectionCommand.cpp#L984
This is to avoid any crash and harden the function. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-11-30 16:40:51 PST
Committed
257203@main
(b83027e6d7d0): <
https://commits.webkit.org/257203@main
> Reviewed commits have been landed. Closing PR #6932 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-11-30 16:41:17 PST
<
rdar://problem/102835623
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug