Bug 248466 - [ews] re-run-layout-tests should use results database instead of doing clean-tree runs
Summary: [ews] re-run-layout-tests should use results database instead of doing clean-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-29 06:44 PST by Aakash Jain
Modified: 2022-12-08 13:04 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-11-29 06:44:48 PST
[ews] re-run-layout-tests should use results database instead of doing clean-tree runs.

For example in https://ews-build.webkit.org/#/builders/10/builds/167694 layout-tests step had 4 failures and 3 of them were pre-existing as per results db (see https://ews-build.webkit.org/#/builders/10/builds/167694/steps/16/logs/stdio), but even though the fourth one (streams/readable-stream-default-controller-error.html) wasn't failing in results db, it was actually flaky, and it did not fail in re-run-layout-tests step (https://ews-build.webkit.org/#/builders/10/builds/167694/steps/22/logs/test-failures doesn't have that test failure).

EWS did run-layout-tests-without-change (after compiling webkit) and reached this conclusion, but all that extra compilation and run-layout-tests-without-change could have been avoided, if re-run-layout-tests  consulted results database.
Comment 1 Radar WebKit Bug Importer 2022-11-29 07:16:03 PST
<rdar://problem/102764839>
Comment 2 Aakash Jain 2022-11-29 07:16:50 PST
Pull request: https://github.com/WebKit/WebKit/pull/6917
Comment 3 Aakash Jain 2022-11-29 07:19:28 PST
This is also needed in cases like https://ews-build.webkit.org/#/builders/10/builds/167706 where the first layout-test run failed to run because of some reason (e.g.: infra issue).
Comment 4 EWS 2022-11-29 08:00:05 PST
Committed 257117@main (a6df5e4d036f): <https://commits.webkit.org/257117@main>

Reviewed commits have been landed. Closing PR #6917 and removing active labels.
Comment 5 Aakash Jain 2022-11-29 08:27:21 PST
More examples where this change would have helped:
https://ews-build.webkit.org/#/builders/60/builds/44663 (flaky failure in first run)

https://ews-build.webkit.org/#/builders/10/builds/167706 (first run failed due to infra issue)
Comment 6 Aakash Jain 2022-11-29 09:09:22 PST
Restarted EWS to pick up this change.