Bug 24846 – HTMLMediaElement should implement 'autobuffer' attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric Carlson]

HTMLMediaElement still doesn't implement the 'autobuffer' attribute, http://www.whatwg.org/specs/web-apps/current-work/multipage/video.html#attr-media-autobuffer.

[Eric Carlson]

Created attachment 29038 [details]
proposed patch

[Darin Adler]

Comment on attachment 29038 [details]
proposed patch

> +    setBooleanAttribute(autobufferAttr, b);
> +    if (m_player)
> +        m_player->setAutobuffer(b);

This is not the right way to bind an attribute to a back-end player property. I haven't looked at the other attributes to see if you're doing it that way. The correct place to do the mapping is in the parseMappedAttribute function. The setter should only set the attribute and the back end effect should be triggered by parseMappedAttribute.

Otherwise, setting the attribute via setAttribute or by setting the attribute in the initial document won't work.

> +void MediaPlayer::setAutobuffer(bool b)
> +{
> +    m_autobuffer = b;
> +    m_private->setAutobuffer(b);
> +}

Since we already know the old value here, I suggest we call the private function only if the value is changing. That way if the private version has to do some real work it won't get done if there's no change.

review- because of the first comment above

[Eric Carlson]

Created attachment 29077 [details]
revised patch

Revised per review.

[Darin Adler]

Comment on attachment 29077 [details]
revised patch

r=me

[Eric Carlson]

Committed revision 42141.