Bug 248450 – Fix CSS.supports behaviour with regards to !important and whitepace

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ahmad Saleem]

Hi Team,

Just another bug report based on Blink's comment and our failing test cases:

Failing Test Case - https://jsfiddle.net/wvsu7koh/show

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/36890765b05b48d8065737682b4e878645b601b2

Webkit GitHub Source - https://github.com/WebKit/WebKit/blob/f3dfd0cc716eec21249cf1b3544fff9303053a0a/Source/WebCore/css/DOMCSSNamespace.cpp#L45

Just wanted to raise bug for future purposes. Thanks!

[Sam Sneddon [:gsnedders]]

To note, this is specifically CSS.supports (i.e., the JS-exposed API) and not @supports.

[Ahmad Saleem]

https://github.com/WebKit/WebKit/pull/6949

[EWS]

Committed 257196@main (4b4a31ba7117): <https://commits.webkit.org/257196@main>

Reviewed commits have been landed. Closing PR #6949 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/102827775>

[Darin Adler]

I believe that the test imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks.html has been crashing in debug builds since this change landed.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 248634

[Ahmad Saleem]

https://github.com/WebKit/WebKit/pull/7068

[EWS]

Committed 257280@main (9d5c6857a50c): <https://commits.webkit.org/257280@main>

Reviewed commits have been landed. Closing PR #7068 and removing active labels.

[Karl Rackler]

Reverted by https://github.com/WebKit/WebKit/pull/7071

[EWS]

Committed 257286@main (3401a13c6836): <https://commits.webkit.org/257286@main>

Reviewed commits have been landed. Closing PR #7071 and removing active labels.

[Karl Rackler]

Revert because it broke the build for the bots

[Ahmad Saleem]

Third Time Charm - https://github.com/WebKit/WebKit/pull/7100

[EWS]

Committed 257313@main (30880fe8446d): <https://commits.webkit.org/257313@main>

Reviewed commits have been landed. Closing PR #7100 and removing active labels.