Bug 24841 - Fix linking against QtWebKit for RVCT and Symbian
Summary: Fix linking against QtWebKit for RVCT and Symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-03-26 07:48 PDT by Laszlo Gombos
Modified: 2009-07-07 20:57 PDT (History)
3 users (show)

See Also:


Attachments
Fix linking against QtWebKit for RVCT and Symbian (1.07 KB, patch)
2009-03-26 07:54 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff
Revised patch based on feedback received ! (1.68 KB, patch)
2009-03-30 18:11 PDT, Laszlo Gombos
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-03-26 07:48:24 PDT
Fix linking against QtWebKit for RVCT and Nokia/Symbian x86 compiler (Carbide) by fixing the EXPORT macros.

RVCT and Nokia/Symbian x86 compiler expect similar syntax for marking symbols to be exported as MSVC on WIN.

Patch proposal will follow.
Comment 1 Laszlo Gombos 2009-03-26 07:54:41 PDT
Created attachment 28968 [details]
Fix linking against QtWebKit for RVCT and Symbian

Thanks for Norbert Leser  <norbert.leser@nokia.com> for help.
Comment 2 Laszlo Gombos 2009-03-30 18:11:10 PDT
Created attachment 29103 [details]
Revised patch based on feedback received !

Instead of white-listing Windows and other platforms, remove the test entirely and apply it to all platforms supported by Qt.

Thanks for Kristian Amlie, Norbert Leser and Simon Hausmann for help/feedback !
Comment 3 Simon Hausmann 2009-04-14 13:15:34 PDT
Thanks Laszlo, landed in r42515