WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248407
Fix Typo in WebGLRenderingContextBase.h for "texParameter" helper function
https://bugs.webkit.org/show_bug.cgi?id=248407
Summary
Fix Typo in WebGLRenderingContextBase.h for "texParameter" helper function
Ahmad Saleem
Reported
2022-11-28 09:37:51 PST
Hi Team, While going through Blink commit, I found another typo, which we still have and it would be good to fix. Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/01e308688d652724afbc976dd1dbf6a37d662603
Webkit GitHub Source -
https://github.com/WebKit/WebKit/blob/1b6e6070bbb4454799b98ee84c5f0a72526b24f0/Source/WebCore/html/canvas/WebGLRenderingContextBase.h#LL1019
Here it is: - void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat parami, GCGLint paramf, bool isFloat); + void texParameter(GCGLenum target, GCGLenum pname, GCGLfloat paramf, GCGLint parami, bool isFloat); It is fixed in Chromium / Blink - checked via source.chromium.org, just wanted to raise bug before fixing this. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-11-28 10:22:22 PST
Committed
257077@main
(0af23318960c): <
https://commits.webkit.org/257077@main
> Reviewed commits have been landed. Closing PR #6867 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-11-28 10:23:18 PST
<
rdar://problem/102723598
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug