WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248325
No need to check for auto lengths or calculated values in valueForImageSliceSide
https://bugs.webkit.org/show_bug.cgi?id=248325
Summary
No need to check for auto lengths or calculated values in valueForImageSliceSide
Oriol Brufau
Reported
2022-11-24 17:02:34 PST
https://searchfox.org/wubkat/rev/fde0f31b8e7849e3eb1bf6c82439b4b9a5d31baf/Source/WebCore/css/ComputedStyleExtractor.cpp#226-240
The check for auto lengths was added in
bug 221856
, but I'm assuming it was by mistake, since border-image-slice doesn't support auto, unlike border-image-width. The check for calculated values was added in
bug 131480
, since back then animations could wrongly produce that. But it seems that has been fixed and now a number and a percentage just interpolate discretely.
Attachments
Add attachment
proposed patch, testcase, etc.
Oriol Brufau
Comment 1
2022-11-24 17:05:53 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6796
Radar WebKit Bug Importer
Comment 2
2022-12-01 17:03:18 PST
<
rdar://problem/102883509
>
Oriol Brufau
Comment 3
2023-03-23 06:39:16 PDT
Bug 254063
removed the isAuto check.
EWS
Comment 4
2023-03-25 16:29:59 PDT
Committed
262121@main
(1a42ba835f13): <
https://commits.webkit.org/262121@main
> Reviewed commits have been landed. Closing PR #6796 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug