Bug 248295 - Remove WebPage::performDefaultBehaviorForKeyEvent
Summary: Remove WebPage::performDefaultBehaviorForKeyEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-23 17:34 PST by Fujii Hironori
Modified: 2022-11-25 02:33 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.93 KB, patch)
2022-11-23 17:37 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (9.13 KB, patch)
2022-11-24 16:41 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-11-23 17:34:13 PST 
Remove WebPage::performDefaultBehaviorForKeyEvent

256929@main (bug#247949) added a code to EventHandler for keyboard scrolling.
WinCairo was the last port using WebPage::performDefaultBehaviorForKeyEvent for keyboard scrolling.
Removed it.
Comment 1 Fujii Hironori 2022-11-23 17:37:14 PST 
Created attachment 463700 [details]
Patch
Comment 2 Fujii Hironori 2022-11-23 20:31:40 PST 
Comment on attachment 463700 [details]
Patch

AppleWin EWS reported an regression.
  fast/dom/vertical-scrollbar-in-rtl.html [ Failure ]
Comment 3 Fujii Hironori 2022-11-24 16:41:59 PST 
Created attachment 463721 [details]
Patch
Comment 4 Fujii Hironori 2022-11-25 01:53:12 PST 
Comment on attachment 463721 [details]
Patch

Thank you for the review.
Comment 5 EWS 2022-11-25 02:32:28 PST 
Committed 257015@main (3ac7a6666750): <https://commits.webkit.org/257015@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463721 [details].
Comment 6 Radar WebKit Bug Importer 2022-11-25 02:33:18 PST 
<rdar://problem/102662830>