WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
248191
Simplify TypingCommand::makeEditableRootEmpty() by removing firstElementChild
https://bugs.webkit.org/show_bug.cgi?id=248191
Summary
Simplify TypingCommand::makeEditableRootEmpty() by removing firstElementChild
Ahmad Saleem
Reported
2022-11-21 13:47:39 PST
Hi Team, While going through Blink commits, I came across another potential simplification: Blink Commit -
https://src.chromium.org/viewvc/blink?view=revision&revision=180673
Webkit GitHub -
https://github.com/WebKit/WebKit/blob/68c7e095336e350fb25defd9c5e2cb040a0764e2/Source/WebCore/editing/TypingCommand.cpp#L620
It will simplifies HTML editing code. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2022-11-22 13:24:53 PST
Committed
256950@main
(b78015aa9a05): <
https://commits.webkit.org/256950@main
> Reviewed commits have been landed. Closing PR #6711 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2022-11-22 13:25:17 PST
<
rdar://problem/102612245
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug