UTF16Char is going away. http://code.google.com/p/google-url/source/detail?r=100
Created attachment 28947 [details] Do it Brett's really the one who should look at this, but Dimitri's a real reviewer, so you two can duke it out.
looks good to me
Comment on attachment 28947 [details] Do it Me too. Although why char16 over UChar or unsigned short or whatever other char types we use in WebCore? I've never seen char16 used in WebCore before... Maybe I've just not paid attention.
char16 is because we need to access these templates in GoogleURL, and that's how it (now) refers to them. GoogleURL gets its char16/string16 support from its restricted version of the Chromium base. KURLGoogle is the "glue" between WebKit and GoogleURL, it shouldn't leak/expose char16 or string16 to the rest of WebKit, and it doesn't. From WebKit's perspective, it's just platform-specific stuff.
Mark: but the appearance of char16 in WebCore/platform/KURLGooglePrivate.h suggests that there is some considerable leakage. it seems unfortunate to require the presence of a base/string16.h header when building WebKit when we don't actually need string16... we just need something exactly equivalent to UChar.
Mark: instead of trying to teach GoogleURL to know about a global char16 type, I think it would be better to let it keep its own UTF16Char type, but then define it in a compatible with char16 and UChar fashion, like what is done at the bottom of this file: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebKit/chromium/public/WebCommon.h?view=markup
Comment on attachment 28947 [details] Do it Based on Darin's comments, I'll remove my review, and let you and Darin sort this one out. :)
KURLGoogle is gone.