Bug 248127 - Cleanup StyleProperties::fontSynthesisValue()
Summary: Cleanup StyleProperties::fontSynthesisValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-19 02:29 PST by Tim Nguyen (:ntim)
Modified: 2022-11-19 10:45 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-11-19 02:29:43 PST 
- Use `propertyAsValueID` instead of custom lambda, it is possible since longhands are never added implicitly.
- Always do checks against the value ID (it is now possible now that we include the `isCSSWideKeyword()` function)
- Use pattern consistent with other methods for appending the strings to the string builder.
Comment 1 Radar WebKit Bug Importer 2022-11-19 02:30:03 PST 
<rdar://problem/102544812>
Comment 2 Tim Nguyen (:ntim) 2022-11-19 02:32:08 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6670
Comment 3 EWS 2022-11-19 10:45:37 PST 
Committed 256877@main (55fafd865860): <https://commits.webkit.org/256877@main>

Reviewed commits have been landed. Closing PR #6670 and removing active labels.