Bug 248108 – AX: Dynamic aria-disabled changes don't update AXPropertyName::IsEnabled for descendants

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

https://w3c.github.io/aria/#aria-disabled

> The state of being disabled applies to the element with aria-disabled and all focusable descendant elements of the element on which the aria-disabled attribute is applied.

[Radar WebKit Bug Importer]

<rdar://problem/102534000>

[Tyler Wilcock]

Created attachment 463616 [details]
Patch

[chris fleizach]

Comment on attachment 463616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463616&action=review

> COMMIT_MESSAGE:9
> +its descendants, too. This is required becaues aria-disabled also

because

[Tyler Wilcock]

Created attachment 463763 [details]
Patch

[EWS]

Committed 257159@main (e113b29b327f): <https://commits.webkit.org/257159@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463763 [details].

[Fujii Hironori]

Comment on attachment 463763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463763&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:414
> +    AXLOG(makeString("Updating properties ", properties, " for objectID ", axObject.objectID().loggingString()));

Does this code generate an expected log string for `properties`?

[Tyler Wilcock]

(In reply to Fujii Hironori from comment #6)
> Comment on attachment 463763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=463763&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:414
> > +    AXLOG(makeString("Updating properties ", properties, " for objectID ", axObject.objectID().loggingString()));
> 
> Does this code generate an expected log string for `properties`?
Nope. Noticed that but haven't got around to fixing it yet.