NEW 248041
Style Fixes pushed smartly similar to missing headers 
https://bugs.webkit.org/show_bug.cgi?id=248041
Summary Style Fixes pushed smartly similar to missing headers
Ahmad Saleem
Reported 2022-11-17 08:56:49 PST
Hi Team, Another suggestion, right now "Style Script" run each commit and if there are some issue like not following code practices is something and it is stricter code quality control but at the same time it can be smarter: Scenario - if there are only style issue because someone used if {...} (curly brackets) with just one argument while it compiles and passed all layout test, I think fixing the style and running all EWS layout suite again is pointless. Smarter Approach - compile list of all PR pushed weekly with style issue (some common) and some script fix them in one go and do one PR automatically and merge them. ____ As for keeping the user informed about issue in the style, rather than using ❌ , it would be better to use ⚠️ as icon and post comment on "GitHub" and link to post explaining how Webkit smarter control can fix it automatically after the week and it is to optimise resources. ____ These for some common style issues would enable the contributor to push the patches without worrying that they have to run the EWS again now that they had made some 'style" error. Please ignore if it might have some concerns or down the line complex issue. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2022-11-17 19:36:28 PST
I don't think that we should skip EWS for style follow-ups. It is actually very likely for the author to make an outstandingly silly mistake in a simple follow-up, because they are already thinking about something else, and aren't testing anything locally any more. I've certainly been guilty of this.
Radar WebKit Bug Importer
Comment 2 2022-11-24 08:57:16 PST
<rdar://problem/102649581>
Note You need to log in before you can comment on or make changes to this bug.