RESOLVED FIXED 248012
Update commit message template to request an explanation of why a PR fixes the bug 
https://bugs.webkit.org/show_bug.cgi?id=248012
Summary Update commit message template to request an explanation of why a PR fixes th...
David Kilzer (:ddkilzer)
Reported 2022-11-16 19:08:42 PST
Update commit message template to request a brief explanation of why a PR fixes the bug. It's always easiest to explain what a patch does, but when reviewing a patch or looking at a previously committed patch, the most useful information that a commit message could contain is why (or how) the changes in the patch actually fix the bug. Most folks already do this, so this just formalizes a placeholder for it.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-11-16 19:09:22 PST
<rdar://problem/102447501>
David Kilzer (:ddkilzer)
Comment 2 2022-11-16 19:16:31 PST
Pull request: https://github.com/apple/WebKit/pull/214
David Kilzer (:ddkilzer)
Comment 3 2022-11-16 19:28:24 PST
Pull request: https://github.com/WebKit/WebKit/pull/6579
Fujii Hironori
Comment 4 2022-11-17 17:42:34 PST
We have one more template there. https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md
David Kilzer (:ddkilzer)
Comment 5 2022-11-17 19:51:16 PST
(In reply to Fujii Hironori from comment #4) > We have one more template there. > https://github.com/WebKit/WebKit/blob/main/.github/pull_request_template.md Thanks! Updated the PR.
EWS
Comment 6 2022-11-18 08:30:41 PST
Committed 256835@main (0e7830380b81): <https://commits.webkit.org/256835@main> Reviewed commits have been landed. Closing PR #6579 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.