Bug 24797 - Improve wxWebKit keyboard shortcuts
: Improve wxWebKit keyboard shortcuts
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-03-25 01:26 PST by
Modified: 2009-05-05 17:51 PST (History)


Attachments
The Fix (9.04 KB, patch)
2009-03-25 01:30 PST, Diggilin
no flags Review Patch | Details | Formatted Diff | Diff
Actually Working Fix (15.51 KB, patch)
2009-03-25 22:40 PST, Diggilin
no flags Review Patch | Details | Formatted Diff | Diff
more complete keyboard shortcuts support (25.70 KB, patch)
2009-04-01 00:22 PST, Diggilin
no flags Review Patch | Details | Formatted Diff | Diff
Moved shortcut => action map to shared location (26.96 KB, patch)
2009-04-24 23:56 PST, Diggilin
kevino: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-03-25 01:26:30 PST
wxWebKit cannot scroll with either the mouse wheel or keyboard.
------- Comment #1 From 2009-03-25 01:30:37 PST -------
Created an attachment (id=28926) [details]
The Fix
------- Comment #2 From 2009-03-25 05:33:50 PST -------
Don't commit first patch, I'll have a second one up tomorrow (GMT+8) that handles key scrolling properly (as in, after webkit has handled it).
------- Comment #3 From 2009-03-25 22:40:11 PST -------
Created an attachment (id=28963) [details]
Actually Working Fix
------- Comment #4 From 2009-04-01 00:22:40 PST -------
Created an attachment (id=29156) [details]
more complete keyboard shotcuts support

This is complete and easier to extend. (with a big thanks to whoever designed the windows port's shortcuts)
------- Comment #5 From 2009-04-01 18:40:39 PST -------
I think the bug summary is too limited for what this patch deals with, so I'm renaming it.
------- Comment #6 From 2009-04-05 12:10:40 PST -------
Much of this patch is a straight copy and paste of the Windows code used to implement editing key events. As such, I'd rather move the Windows code up to some common location where both the Windows and wx ports can use it (and I suspect other ports will want to as well once it is available). Maybe in Editor? As this involves other ports, it would probably be good to bring this up on webkit-dev and ask. The idea would be that ports would not call these methods whenever they want to provide a different behavior, but otherwise they'd default to the behavior here.

Once that's done, the only alteration that I think we would need to make would be to make isSystemKey a cross-platform method of PlatformKeyboardEvent, and in wx we'd have it always return false, even on Windows unfortunately because wx makes no distinction between a 'system' and 'non-system' key.
------- Comment #7 From 2009-04-24 23:56:53 PST -------
Created an attachment (id=29782) [details]
Moved shortcut => action map to shared location
------- Comment #8 From 2009-05-05 17:51:52 PST -------
Landed in r43265, thanks!