Bug 247919 - Fix font-variant shorthand serialization
Summary: Fix font-variant shorthand serialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-14 14:57 PST by Tim Nguyen (:ntim)
Modified: 2022-11-14 19:47 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-11-14 14:57:48 PST 
- We should collapse longhands to the shorthand when possible
- Clean up fontVariantValue() to not consider implicit/explicit anymore used to represent default/system values
- Refactor to remove appendFontLonghandValueIfExplicit()
Comment 1 Radar WebKit Bug Importer 2022-11-14 14:58:01 PST 
<rdar://problem/102339716>
Comment 2 Tim Nguyen (:ntim) 2022-11-14 15:20:10 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6492
Comment 3 Tim Nguyen (:ntim) 2022-11-14 18:31:24 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/36966
Comment 4 EWS 2022-11-14 19:47:32 PST 
Committed 256681@main (cee0d60d4af3): <https://commits.webkit.org/256681@main>

Reviewed commits have been landed. Closing PR #6492 and removing active labels.