WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
247900
Add support for skip-ews GitHub label
https://bugs.webkit.org/show_bug.cgi?id=247900
Summary
Add support for skip-ews GitHub label
Aakash Jain
Reported
2022-11-14 08:11:28 PST
Add support for Skip-EWS GitHub label. This label can be applied to a PR to skip EWS runs. There might be various scenarios in which people might want to apply such a label. Foe e.g: - Some engineers might want to abort EWS as soon as the they know that the change is going to be bad (e.g: an important ews on their patch failed, and they don't want to keep running on all other ewses). - Someone just re-uploaded the change after doing a trivial change (add reviewer name, fix typo in PR title etc.) - Admins wants to stop a bad PR (which might be breaking EWS bots) from further processing
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2022-11-14 08:14:05 PST
Note that, in bugzilla world, there are three ways to do similar thing: 1) r- the patch 2) mark the patch as obsolete from bugzilla UI 3) --no-ews while uploading the patch In GitHub world, we don't have any way to do this. Equivalent of r- in GitHub is marking the PR as Request changes, which still triggers the EWS. There is no way to mark a commit as obsolete in GitHub UI without uploading a new commit.
Aakash Jain
Comment 2
2022-11-14 08:19:44 PST
Pull request:
https://github.com/WebKit/WebKit/pull/6476
EWS
Comment 3
2022-11-16 17:26:13 PST
Committed
256760@main
(57ba798e7aa4): <
https://commits.webkit.org/256760@main
> Reviewed commits have been landed. Closing PR #6476 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2022-11-16 17:27:17 PST
<
rdar://problem/102444473
>
Jonathan Bedard
Comment 5
2022-11-17 16:25:11 PST
Re-opening for pull request
https://github.com/apple/WebKit/pull/216
EWS
Comment 6
2022-11-18 08:37:23 PST
Committed
252432.837@safari-7614-branch
(8dbf19696f48): <
https://commits.webkit.org/252432.837@safari-7614-branch
> Reviewed commits have been landed. Closing PR #216 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug