RESOLVED FIXED 247870
[Win] REGRESSION(255254@main): TestWTF.WTF_RunLoopDeathTest.CapabilityIsCurrentFailureAssertsDeathTest is failing
https://bugs.webkit.org/show_bug.cgi?id=247870
Summary [Win] REGRESSION(255254@main): TestWTF.WTF_RunLoopDeathTest.CapabilityIsCurre...
Fujii Hironori
Reported 2022-11-13 17:57:50 PST
[Win] REGRESSION(255254@main): TestWTF.WTF_RunLoopDeathTest.CapabilityIsCurrentFailureAssertsDeathTest is failing since Buildbot: builder WinCairo-64-bit-WKL-Debug-Tests build 2736 https://build.webkit.org/#/builders/32/builds/2736 TestWTF.WTF_RunLoopDeathTest.CapabilityIsCurrentFailureAssertsDeathTest C:\BW\WinCairo-64-bit-WKL-Debug-Build\build\Source\ThirdParty\gtest\src\gtest-port.cc:865 Failed Syntax error at index 35 in simple regular expression "ASSERTION FAILED: runLoop.isCurrent()": '(' is unsupported. C:\BW\WinCairo-64-bit-WKL-Debug-Build\build\Source\ThirdParty\gtest\src\gtest-port.cc:865 Failed Syntax error at index 36 in simple regular expression "ASSERTION FAILED: runLoop.isCurrent()": ')' is unsupported. C:\BW\WinCairo-64-bit-WKL-Debug-Build\build\Tools\TestWebKitAPI\Tests\WTF\RunLoop.cpp:256 Death test: { WTF::initializeMainThread(); Thread::create("CapabilityIsCurrentNegative thread", [&] { assertIsCurrent(RunLoop::main()); })->waitForCompletion(); } Result: died but not with expected error. Expected: contains regular expression "ASSERTION FAILED: runLoop.isCurrent()" Actual msg: [ DEATH ] ASSERTION FAILED: runLoop.isCurrent() [ DEATH ] C:\BW\WinCairo-64-bit-WKL-Debug-Build\build\WebKitBuild\Debug\WTF\Headers\wtf/RunLoop.h(290) : WTF::assertIsCurrent [ DEATH ] 1 00007FF8FA44248B WTFCrash [ DEATH ] 2 00007FF8ECDADACE (null) [ DEATH ] 3 00007FF8ED26EF34 (null) [ DEATH ] 4 00007FF8ED260108 (null) [ DEATH ] 5 00007FF8ED2642AB (null) [ DEATH ] 6 00007FF8FA45A503 WTF::CrossThreadTaskHandler::setCompletionCallback [ DEATH ] 7 00007FF8FA4F85F8 WTF::Thread::dump [ DEATH ] 8 00007FF8FA5D4014 WTF::Thread::currentMayBeNull [ DEATH ] 9 00007FF9064B1FFA o_exp [ DEATH ] 10 00007FF9083E7974 BaseThreadInitThunk [ DEATH ] 11 00007FF9247AA271 RtlUserThreadStart [ DEATH ]
Attachments
Patch (1.37 KB, patch)
2022-11-13 18:03 PST, Fujii Hironori
no flags
Fujii Hironori
Comment 1 2022-11-13 18:03:23 PST
Fujii Hironori
Comment 2 2022-11-13 20:58:08 PST
Comment on attachment 463510 [details] Patch Thank you for the review.
EWS
Comment 3 2022-11-13 21:46:35 PST
Committed 256632@main (d2bbb9b54ab2): <https://commits.webkit.org/256632@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 463510 [details].
Radar WebKit Bug Importer
Comment 4 2022-11-13 21:47:17 PST
Note You need to log in before you can comment on or make changes to this bug.