Bug 247859 - Add floats to overflow of the direct containing block only
Summary: Add floats to overflow of the direct containing block only
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-13 04:57 PST by Ahmad Saleem
Modified: 2022-11-20 04:58 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-13 04:57:15 PST 
Hi Team,

While going through Blink commits, I found another potential fix, which can be brought to Webkit:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/5b8a044ea5e398a0863d28c38855adcbd1a421c5

Webkit GitHub - https://github.com/WebKit/WebKit/blob/5a9504aef82d929917a680a05a3fc17f7f6b4dde/Source/WebCore/rendering/RenderBlockFlow.cpp#LL2144

and it should be changed from:

floatingObject.isDescendant()

to

floatingObject.shouldPaint()

______

Just wanted to raise it to fix this bug. Thanks!
Comment 1 Ahmad Saleem 2022-11-13 05:21:18 PST 
If I read following bug clearly:

This was final revision to the related bug - https://chromium.googlesource.com/chromium/src/+/0f639ede1ca727f4684766ec2427a341e413be7b

and it mentions that this was fixed with this:

https://chromium.googlesource.com/chromium/src/+/f01027994dbd35c1657c31d99045b45edff373fe

and this current commit was in reference to other approach of bug fixing. I am running this via EWS to see, if we get any passes else, I will close this bug. Thanks!
Comment 2 Radar WebKit Bug Importer 2022-11-20 04:58:15 PST 
<rdar://problem/102559813>