RESOLVED FIXED247856
Simplify includesAdjacentEdges in BorderEdge.h 
https://bugs.webkit.org/show_bug.cgi?id=247856
Summary Simplify includesAdjacentEdges in BorderEdge.h
Ahmad Saleem
Reported 2022-11-13 03:11:33 PST
Hi Team, While going through Blink commits, I came across another simplification / refactoring for "adjacency test" for Border Painting: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/45cd7b0546450187bb5f781d47778b739911341f Webkit GitHub - https://github.com/WebKit/WebKit/blob/5a9504aef82d929917a680a05a3fc17f7f6b4dde/Source/WebCore/rendering/BorderEdge.h#L77 I am raising this bug so if this can be applied in Webkit context. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2022-11-13 08:09:06 PST
(In reply to Ahmad Saleem from comment #0) > I am raising this bug so if this can be applied in Webkit context. Yep, the equivalent would be: flags.containsAny({ BoxSideFlag::Top, BoxSideFlag::Bottom }) && flags.containsAny({ BoxSideFlag::Left, BoxSideFlag::Right })
Ahmad Saleem
Comment 2 2022-11-13 12:05:25 PST
https://github.com/WebKit/WebKit/pull/6445
EWS
Comment 3 2022-11-13 20:40:10 PST
Committed 256631@main (cf6c7427c391): <https://commits.webkit.org/256631@main> Reviewed commits have been landed. Closing PR #6445 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2022-11-13 20:41:20 PST
<rdar://problem/102302676>
Note You need to log in before you can comment on or make changes to this bug.