Bug 247848 - Making VisibleSelection operator== take base and extent into account
Summary: Making VisibleSelection operator== take base and extent into account
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-12 15:06 PST by Ahmad Saleem
Modified: 2022-11-26 01:55 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2022-11-12 15:06:04 PST
Hi Team,

While going through Blink Commits, I came across another interesting commit, which is something fixes long press text selections and dragging solution but it does not have any test case to validate the change.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=193950

Webkit GitHub - https://github.com/WebKit/WebKit/blob/50b63f352a0727a36aea7b4f380235a1048ffe7e/Source/WebCore/editing/VisibleSelection.h#L166

Since it does not have test case, I cannot verify whether we are still breaking something or not but if it can fix some edge cases of text selection and dragging (as it claims) then I think it would be good to consider.

Appreciate if someone can share insight into it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2022-11-19 15:07:16 PST
<rdar://problem/102552348>
Comment 2 Ahmad Saleem 2022-11-26 01:55:00 PST
After discussing with rniwa, it seems that landing this without test case would not be ideal scenario and I would try to find relevant testcase to see how it affects us but as of right now, I would focus on other.

PR - https://github.com/WebKit/WebKit/pull/6563

Although we do have bugs around 'long press', 'drag', 'selection' and 'base and extent' in general. Thanks!