Bug 24782 - CSS clip with auto values broken
Summary: CSS clip with auto values broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-24 12:38 PDT by Simon Fraser (smfr)
Modified: 2009-03-24 13:46 PDT (History)
0 users

See Also:


Attachments
Patch, changelog (7.04 KB, patch)
2009-03-24 13:40 PDT, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-03-24 12:38:30 PDT
The fix for bug 24753 broke css clip with auto values.
Comment 1 Simon Fraser (smfr) 2009-03-24 12:39:17 PDT
This breakage shows in two tests:
fast/clip/016.html
fast/clip/outline-overflowClip.html
Comment 2 Simon Fraser (smfr) 2009-03-24 13:40:10 PDT
Created attachment 28909 [details]
Patch, changelog
Comment 3 mitz 2009-03-24 13:43:32 PDT
Comment on attachment 28909 [details]
Patch, changelog

> -            left = Length(rect->left()->computeLengthIntForLength(style(), zoomFactor), Fixed);
> +            
> +            top = convertToLength(rect->top(), style(), zoomFactor);

You are adding extra whitespace there. r=me
Comment 4 Simon Fraser (smfr) 2009-03-24 13:46:34 PDT
http://trac.webkit.org/changeset/41950