Bug 247802 - RemoteAudioDestinationProxy base class is platform specific
Summary: RemoteAudioDestinationProxy base class is platform specific
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-11-11 06:39 PST by Kimmo Kinnunen
Modified: 2022-11-16 05:20 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-11-11 06:39:56 PST 
RemoteAudioDestinationProxy base class is platform specific

Remote proxies in general should work on all platforms.

The platform specificness causes ifdefing. 
The ifdefing in the RemoteAudioDestinationProxy causes ifdefing for in RemoteAudioDestinationManager messages.
Ifdefing in messages is problematic as the argument ifdefs cause new message names and that gets unmanageable.

All this is because GStreamer does not yet use RemoteAudioDestinationProxy but still compiles it.
Comment 1 Radar WebKit Bug Importer 2022-11-11 06:40:48 PST 
<rdar://problem/102238646>
Comment 2 Kimmo Kinnunen 2022-11-11 07:04:08 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6396
Comment 3 EWS 2022-11-16 05:20:30 PST 
Committed 256729@main (3fac3faf1d5b): <https://commits.webkit.org/256729@main>

Reviewed commits have been landed. Closing PR #6396 and removing active labels.