Bug 247771 – CSSOM serializes most shorthands without checking !important flag

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Oriol Brufau]

From https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue

3. If important flags of all declarations in list are same, then return the serialization of list.
4. Return the empty string. 

Run this code:

var allCSSProps = new Set();
for (let obj = document.createElement("div").style; obj; obj = Reflect.getPrototypeOf(obj)) {
  for (let name of Object.getOwnPropertyNames(obj)) {
    let prop = name.replace(/[A-Z]/g, c => "-" + c.toLowerCase());
    if (CSS.supports(prop, "initial")) {
      allCSSProps.add(prop);
    }
  }
}
var style = document.createElement("div").style;
var bad = [];
var good = [];
for (let prop of allCSSProps) {
  style.cssText = "";
  style.setProperty(prop, "initial");
  if (style.length > 1) {
    style.setProperty(style[0], "initial", "important");
    if (style.getPropertyValue(prop) !== "") {
      bad.push(prop);
    } else good.push(prop);
  }
}
bad;

Expected: empty array

Actual: [
  "-epub-text-emphasis",
  "-webkit-animation",
  "-webkit-border-after",
  "-webkit-border-before",
  "-webkit-border-end",
  "-webkit-border-start",
  "-webkit-column-rule",
  "-webkit-columns",
  "-webkit-flex",
  "-webkit-flex-flow",
  "-webkit-mask",
  "-webkit-mask-position",
  "-webkit-perspective-origin",
  "-webkit-text-decoration",
  "-webkit-text-emphasis",
  "-webkit-text-stroke",
  "-webkit-transform-origin",
  "-webkit-transition",
  "animation",
  "background",
  "background-position",
  "border-block-end",
  "border-block-start",
  "border-bottom",
  "border-inline-end",
  "border-inline-start",
  "border-left",
  "border-right",
  "border-spacing",
  "border-top",
  "column-rule",
  "columns",
  "container",
  "flex",
  "flex-flow",
  "font",
  "font-synthesis",
  "font-variant",
  "grid-area",
  "grid-column",
  "grid-row",
  "grid-template",
  "list-style",
  "marker",
  "mask",
  "mask-position",
  "outline",
  "perspective-origin",
  "place-content",
  "place-items",
  "place-self",
  "text-emphasis",
  "transform-origin",
  "transition"
]

[Oriol Brufau]

Pull request: https://github.com/WebKit/WebKit/pull/6523

[EWS]

Committed 256774@main (dc7aed5d4dc6): <https://commits.webkit.org/256774@main>

Reviewed commits have been landed. Closing PR #6523 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/102454608>