Bug 24777 - WebKit tools are broken on Tiger
Summary: WebKit tools are broken on Tiger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-24 07:50 PDT by Alexey Proskuryakov
Modified: 2009-03-31 14:43 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (1.20 KB, patch)
2009-03-31 03:43 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-03-24 07:50:46 PDT
$ run-safari 
Starting Safari with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/ap/WebKit/WebKitBuild/Debug.
*error: arch takes no arguments

Looks like this was caused by <http://trac.webkit.org/changeset/41696>. It isn't immediately clear to me how to fix it.
Comment 1 Mark Rowe (bdash) 2009-03-24 09:46:27 PDT
The solution is to not use 'arch' to run binaries on Tiger, since it's never necessary and doesn't work in the same way it does on Leopard and beyond.
Comment 2 Alexey Proskuryakov 2009-03-31 03:43:19 PDT
Created attachment 29111 [details]
proposed fix
Comment 3 Mark Rowe (bdash) 2009-03-31 10:14:27 PDT
It may be better to skip setting $architecture at all on Tiger, like we do on non-Mac platforms, since I don't think it's ever useful on Tiger.  This will also avoid having to check for Tiger at places that it is used.
Comment 4 Alexey Proskuryakov 2009-03-31 14:40:59 PDT
Committed r42142.

> It may be better to skip setting $architecture at all on Tiger

I'm pretty much happy with getting my run-safari back. Would you be willing to work on further improving this?
Comment 5 Mark Rowe (bdash) 2009-03-31 14:43:03 PDT
I don't have a Tiger machine to test anything on, so it's not likely I'll be doing anything on this.