Bug 247746 - [WASM-Function-References] Improve type printing for reference types
Summary: [WASM-Function-References] Improve type printing for reference types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247393
  Show dependency tree / graph
 
Reported: 2022-11-10 09:57 PST by Asumu Takikawa
Modified: 2023-11-20 14:35 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2022-11-10 09:57:12 PST 
Type printing in, e.g., error messages, is not great for types using the features from the typed function reference proposal currently.

For example `(ref null extern)` and `(ref extern)` are both printed as "Externref". The printing should take into account nullability and also the index for reference to a type definition.
Comment 1 Radar WebKit Bug Importer 2022-11-17 09:58:18 PST 
<rdar://problem/102472468>
Comment 2 Asumu Takikawa 2023-11-16 08:25:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20611
Comment 3 EWS 2023-11-20 14:35:01 PST 
Committed 270988@main (fd124818fa58): <https://commits.webkit.org/270988@main>

Reviewed commits have been landed. Closing PR #20611 and removing active labels.